Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix hp and mp visible gear latents #5832

Draft
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

TracentEden2
Copy link

@TracentEden2 TracentEden2 commented May 24, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR adds the functionality for two rare types of latent gear. Specifically MP_UNDER_VISIBLE_GEAR and HP_OVER_VISIBLE_GEAR which are used by Uggalepih Pendant and Parade Gorget respectively. Retail testing can be see for example here and JP Wiki.

Still in draft as I figure out how this will interact with another PR I am making to fix other latent and HP issues.

Steps to test these changes

Calculate your HP or MP given only the +HP or +MP in the defined slots (SLOT_MAIN, SLOT_SUB, SLOT_RANGED, SLOT_AMMO, SLOT_BODY, SLOT_HANDS, SLOT_LEGS, SLOT_FEET) and then, with the pendant, for example, check your MATT at different MPs near 51%

Co-Authored-By: andymo <andymo@users.noreply.github.com>
@TracentEden2 TracentEden2 changed the title Fix hp and mp visible gear latents May 24, 2024
@TracentEden2 TracentEden2 marked this pull request as draft May 27, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants