Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest]Holy Crest to IF #5848

Open
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

hooksta4
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Converts The Holy Crest to IF

  • Deleted all logic pertaining to quest NPC's .
  • Moved to defaultActions where appropriate.
  • Adjusted NPC dialog to match capture
  • Added dialog into ID's where appropriate based on above capture.
  • Added enum's where appropriate.

Steps to test these changes

Be on a level 30 job and speak with the dorks in the warehouse. If you change job to something below 30 (xi.settings.main.ADVANCED_JOB_LEVEL) you will not get the same dialog as if you are on a job 30+ even after talking to them once.

[Quest]Holy Crest to IF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant