Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quest]WHM AF1 Messenger From Beyond #5849

Open
wants to merge 1 commit into
base: base
Choose a base branch
from
Open

[Quest]WHM AF1 Messenger From Beyond #5849

wants to merge 1 commit into from
+90 −47

Conversation

hooksta4
Copy link
Contributor

@hooksta4 hooksta4 commented May 29, 2024 •
edited
Loading

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Converts WHM AF1 to IF.

  • Removes logic from NPC files.
  • Adds a dialog when spawning NM.
  • Capture

Steps to test these changes

Be on whm 40+ Speak with Narchera
Pop and Kill NM
Return Tavnazia Pass to Narchera
@claywar claywar changed the title [Quest]WHM AF1 MSG'r From Beyond Jun 16, 2024
claywar
claywar requested changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@claywar claywar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall fairly reasonable, but removing the default and attaching it to a quest is not acceptable. This must be changed.
scripts/quests/sandoria/WHM_AF1_Messenger_From_Beyond.lua Outdated
-- Narcheral: !pos 128 -11 128 231
-- qm2 : !pos -714 -9 68 103
-----------------------------------
local valkID = zones[xi.zone.VALKURM_DUNES]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not abbreviate more than necessary, valkurmID
scripts/quests/sandoria/WHM_AF1_Messenger_From_Beyond.lua Outdated
then
return quest:messageSpecial(valkID.text.FOUL_PRESENSE)
else
return quest:messageSpecial(valkID.text.NOTHING_OUT_OF_ORDINARY)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in DefaultActions
scripts/quests/sandoria/WHM_AF1_Messenger_From_Beyond.lua Outdated
end,

onTrigger = function(player, npc)
return quest:event(688)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not relevant to this quest, and is either a default action or should remain in his script
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made changes to all.. Thanks!
@hooksta4
[Quest]WHM AF1 Messenger From Beyond
21077c5 
[Quest]WHM AF1 MSG'r From Beyond

[Quest]WHM AF1 SG'r From Beyond
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@hooksta4 @claywar