Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest]Tenshodo Membership Conv #5851

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

hooksta4
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Moves Tenshodo Membership logic to IF.
  • Removes related NPC lua file logic.
  • Capture shows quest is never accepted only completed.

Steps to test these changes

  • Can turn in either Tenshodo Invite to complete quest if unable to meet fame requirement, or accept quest and get the application form.
@Xaver-DaRed
Copy link
Contributor

Looks good, just needs to correct some styling

[Quest]Tenshodo Membership Conv

[Quest]Tenshodo Membership Conv

[Quest]Tenshodo Membership Conv
@zach2good zach2good merged commit 5f1adcb into LandSandBoat:base Jul 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants