[Quest]An Undying Pledge Conv

[hooksta4]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

• Converts Quest An Undying Pledge to IF.
• Adds Light Buckler to item.lua
• Removes npc lua logic.
• Adds defaultAction for qm5 and Stray Cloud
• Adds dialog for after quest completion
• Removes trigger area from zone.lua and into IF file
• Removes logic from NM
  - Capture

Steps to test these changes

[claywar]

This charvar should be read into a variable and then used in the condition.

[hooksta4]

What do you mean by this?

[hooksta4]

you mean like local prog = quest:getVar(Blah blah_

if prog == 0 then?

[claywar]

Regardless of what goes on behind the scenes, I'll present the following analogy:

Let's say you're doing a research project on whales, and you need to look up the average length of a newborn humpbacked whale. You have an encyclopedia to look it up, but every time you do, you have to flip through and find the right page.

Instead, what is being suggested is do the research once and write it down. Xaver beat me to the punch, but I wanted to explain why things like these are important, because its less overhead and a better practice.

[hooksta4]

Ok typically in the past if its been more than 2 id do the do that but now will make it for 2 or more. thanks.

[claywar]

Can you please align all of those ='s in each line here? Not sure how this got out of control

[claywar]

Just a small nitpick here, but can you style that similar to other formats? (with --- block under the local)

[Xaver-DaRed]

                    local questProgress = quest:getVar(player, 'Prog')
                    if
                        questProgress == 1 and
                        npcUtil.popFromQM(player, npc, ssgID.mob.GLYRYVILU, { claim = true, hide = 0 })
                    then
                        return quest:messageSpecial(ssgID.text.BODY_NUMB_DREAD)
                    elseif questProgress == 2 then
                        return quest:progressEvent(18)
                    end

To expand:

• As claywar said, whenever you have to check the same thing more than once, store it on a variable first so we dont repeat operations.
• When there is only one condition, theres no need to align the if/elseif separate from the condition or the then

[Xaver-DaRed]

As a general rule, please have this aligned like so (applicable to all PRs)

quest.reward =
{
    item     = xi.item.LIGHT_BUCKLER,
    fameArea = xi.fameArea.NORG,
    fame     = 50,
}