[Quest] Out of the Depths #5866
Conversation
jamesbradleym
force-pushed
the
Out-of-the-Depths
branch
3 times, most recently
from
cb140b0
to
652c5b1
Compare
| { | ||
| fame = 80, | ||
| fameArea = xi.fameArea.BASTOK, | ||
| title = xi.title.TRASH_COLLECTOR, | ||
| gil = 1200, | ||
| } |
There was a problem hiding this comment.
They want these aligned with =
| elseif player:hasKeyItem(xi.ki.OLD_NAMETAG) then | ||
| return quest:progressEvent(309, 0, 5, 0, 601) | ||
| else | ||
| return quest:progressEvent(308, 0) |
There was a problem hiding this comment.
progressEvent usually means there is an onEventFinish - may just use quest:event(308)
There was a problem hiding this comment.
quest:progressEvent() doesn't necesarilly need an onEventFinish()
It just means it has high priority over regular events. We use progressEvent for mandatory steps and steps that progress the quest.
Also, theres no need for that "0" param
return quest:event(308)
There was a problem hiding this comment.
Ok - I was under the impression that, while it would "work" we wanted to keep progressEvent to just that, progressing the event. If its a CS or reminder that didn't move it forward, then use event and thus no onEventFinish.
| end | ||
| end | ||
| end, | ||
|
|
Co-authored-by: jamesbradleym <jamesbradleym@gmail.com> Co-authored-by: dallano <atwood.dallan@hotmail.com>
jamesbradleym
force-pushed
the
Out-of-the-Depths
branch
from
652c5b1
to
3b489f4
Compare
| quest:setVar(player, 'Prog', questProgress + 1) | ||
| elseif option == 2 then | ||
| npcUtil.giveCurrency(player, 'gil', 200) | ||
| player:delKeyItem(xi.ki.POINTED_JUG) | ||
| quest:setVar(player, 'Prog', questProgress + 1) | ||
| elseif option == 3 then | ||
| npcUtil.giveCurrency(player, 'gil', 300) | ||
| player:delKeyItem(xi.ki.CRACKED_CLUB) | ||
| quest:setVar(player, 'Prog', questProgress + 1) | ||
| elseif option == 4 then | ||
| npcUtil.giveCurrency(player, 'gil', 400) | ||
| player:delKeyItem(xi.ki.PEELING_HAIRPIN) | ||
| quest:setVar(player, 'Prog', questProgress + 1) | ||
| elseif option == 5 then | ||
| player:delKeyItem(xi.ki.OLD_NAMETAG) | ||
| quest:setVar(player, 'Prog', 8) |
There was a problem hiding this comment.
Should we use incrementVar instead of setVar + 1?
I affirm:
What does this pull request do?
Implements Quest Out of the Depths based on ASB PR
Corrects some dialogue + new dialogue.
Capture
Steps to test these changes
Complete Quest Out of the Depths