[LUA] Hybrid Weaponskill Damage is Incorrect #5883
Draft
+45
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Bug 5865] Hybrid Weaponskill Damage is Incorrect Hybrid weaponskill base physical damage and bonus magic damage is now computed according to the following references. https://wiki.ffo.jp/html/1261.html https://www.ffxiah.com/forum/topic/33470/the-sealed-dagger-a-ninja-guide/151/#3420836 https://www.ffxiah.com/forum/topic/49614/blade-chi-damage-formula/2/#3171538
|
✨ Thanks for the PR! ✨ This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template. |
Added tp variable computeHybridMagicDamage function.
|
Sorry we have to keep re-running the CI for you manually until you get your first merge in. If you need us to poke it let us know by commenting here. |
|
Ok. I had this drafted as I haven't had the time to do an Arching Arrow test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Hybrid weaponskill base physical damage and bonus magic damage is now computed according to the following references.
Steps to test these changes
Use Piercing Arrow at 3000 TP and record the damage. Then use Flaming Arrow at 3000 TP and verify that you get something close to the following.
Physical Hit - Same as Flaming Arrow
Magic Base = Physical Hit * fTP
Modifier = 0.2 if using gorget/belt, 0.1 if using gorget or belt, 0 otherwise.
Magical Hit = ((Magic Base + mDMG) * MAB * (1/MDB)* Affinity * Day/Weather * SDT * TMDA * WSD + Physical Hit * Modifier