Moved Ranger ability Lua to jobutils #5889
Conversation
|
✨ Thanks for the PR! ✨ This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template. |
|
Draft while i am self testing these changes |
|
Tested on local server on ranger 75 all abilities worked. Will cleanup work and made the necessary changes according to PR and helpful comments |
andeluvian
force-pushed
the
basejobs_jobutils
branch
from
fd15271
to
701d2ff
Compare
|
squashed commits |
andeluvian
requested review from
Mortalelite,
Frankie-hz,
claywar and
Xaver-DaRed
|
Kicked CI so you can see what's still left to do. There's no need to re-tag people for review, if they've interacted with your PR and you re-push I think everyone gets an email. |
|
(I do, at least 🤷♂️) |
|
|
||
| xi.job_utils.ranger.useEagleEyeShot = function(player, target, ability) | ||
| if player:getWeaponSkillType(xi.slot.RANGED) == xi.skill.MARKSMANSHIP then | ||
| action:setAnimation(target:getID(), action:getAnimation(target:getID()) + 1) |
There was a problem hiding this comment.
Did you test this, action doesn't exist in this scope?
There was a problem hiding this comment.
I had a test this morning because I was 100% I did test each skill against an enemy. HOWEVER you are 100% this is mistake on my part, the skill will trigger and fire the arrow, however no damage nor any "action" is taken against the monster itself but the skill will go on cooldown. This was my inexperience and not being careful enough. Will fix
| local playerID = target:getID() | ||
|
|
||
| if arrowsToReturn == 0 then | ||
| action:messageID(playerID, 139) |
There was a problem hiding this comment.
Same: Did you test this, action doesn't exist in this scope?
There was a problem hiding this comment.
Will fix same as eagle eye shot response, my mistake and not being careful enough.
|
|
||
| xi.job_utils.ranger.useShadowbind = function(player, target, ability) | ||
| if player:getWeaponSkillType(xi.slot.RANGED) == xi.skill.MARKSMANSHIP then -- can't have your crossbow/gun held like a bow, now can we? | ||
| action:setAnimation(target:getID(), action:getAnimation(target:getID()) + 1) |
There was a problem hiding this comment.
Same: Did you test this, action doesn't exist in this scope?
There was a problem hiding this comment.
I had a test this morning because I was 100% I did test each skill against an enemy. I believe I will need to investigate into the job ability what it should 100% do. The animation triggers and fires the arrow and the target is bound, no arrow was consumed when I had tested this. Will reinvestigate and fix
andeluvian
force-pushed
the
basejobs_jobutils
branch
from
c6675ed
to
bd41b9a
Compare
andeluvian
force-pushed
the
basejobs_jobutils
branch
from
bd41b9a
to
07772e6
Compare
|
This PR is failing CI. You need to remobe the tabs from the code. Tabs -> 4 spaces |
I affirm:
What does this pull request do? (Please be technical)
All job abilities of the ranger have been moved from scripts/actions/abilities/ to scripts/globals/job_utils/ranger.lua
Steps to test these changes
Go into the game
Make a level 99 or 75 ranger
Test each job ability and see if they work correctly
Special Deployment Considerations