Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest]Blackmail #5890

Open
wants to merge 1 commit into
base: base
Choose a base branch
from
Open

Conversation

hooksta4
Copy link
Contributor

@hooksta4 hooksta4 commented Jun 5, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Converts quest Blackmail to Interaction Framework.

  • Adds defaultAction for Dauperiat.
  • Adds checks for rank 3 (any nation) in order to accept the quest.
    • Because it is in the Chateau, it is assumed that rank 3 (or on the mission to get inside the Chateau), there is no evidence supporting from captures. Putting it at Rank 3 as one wiki mentions it specifically while the other does not.

Steps to test these changes

Talk to NPC to begin. Then repeat as you get floor plans.


[648] = function(player, csid, option, npc)
if player:hasCompletedQuest(quest.areaId, quest.questId) then
quest.fame = 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. fame attached to the quest object does nothing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, lua tables are passed by reference in most places. If your intent is to modify quest.rewards, it will need to be tested with a separate character as well following the modification to ensure it is not permanently changed (my bet is it will be)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Ill just add the addFame() instead.

[Quest]Blackmail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants