Experimental Battlefield: Ouryu Cometh #5905
Conversation
|
This isn't how this battlefield works. |
|
thank you both for your guidance. |
| { | ||
| { | ||
| mobs = { 'Ouryu' }, | ||
| superlink = true, |
There was a problem hiding this comment.
So just one last thing as I look with a fresh mind: Groups superlink to their own, so instead for here and below, you're going to need to use superlinkGroup = 1 instead (can have multiple groups defined, but if they need to link together, need to be the same)
There was a problem hiding this comment.
should be all set, mister. I added the missing elementals as well.
| { | ||
| mobs = { 'Ouryu' }, | ||
| superlink = true, | ||
| death = utils.bind(content.handleAllMonstersDefeated, content), |
There was a problem hiding this comment.
This death handler will most likely need to be defined locally for when this BCNM has loot support since there is no armoury crate, but instead a direct drop to loot pool. For now I would suggest just a comment and a function to set battlefield status to WON
There was a problem hiding this comment.
retested and everything still works as it should.
| entryNpc = 'Unstable_Displacement', | ||
| exitNpc = 'Spatial_Displacement', |
There was a problem hiding this comment.
I'm not well versed on the new battlefield system. How exactly are these strings used? There are several NPC with both of these names, so will any of them trigger the battlefield functions? Do they need to be renamed to be distinguished from the other ones?
There was a problem hiding this comment.
I'm more of a fan of id definitions since it's more clear, but in certain cases it will add all
There was a problem hiding this comment.
For exit, it indeed applies to all so if there are some that this does not apply to, it needs a unique name
There was a problem hiding this comment.
For exit, it indeed applies to all so if there are some that this does not apply to, it needs a unique name
Just so we're on the same page, is that out of scope for this PR? I'm happy to follow up with another to rename the exit NPC to something unique like Spatial_Displacement_BF (for battlefield)
There was a problem hiding this comment.
That is absolutely in scope for this PR. You do not want to assign the exit functions to NPCs where it does not apply.
There was a problem hiding this comment.
For what it's worth I tested this in a party so I could trigger the outside NPCs while having BCNM status and all the outside spatial displacements behaved normally and I only got the exit prompt after entering the battlefield. Still should distinguish them but good to know there seems to be some safety.
There was a problem hiding this comment.
That is absolutely in scope for this PR. You do not want to assign the exit functions to NPCs where it does not apply.
No problem, I've added a commit for that change as well.
I affirm:
What does this pull request do?
Adds an experimental battlefield: Ouryu Cometh
Mainly this PR adds a battlefield script that will make use of the missing ID's which are available to all other battlefield zones.
Without these ID's present, any battlefields added to this zone will error out in the battlefield global.
Steps to test these changes
!pos 732.550 -32.5 -506.544 30
!additem cloud_evoker
Trade it to the Spatial Displacement