Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JobUtils] Ninja job ability refactoring to JobUtils #5918

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[JobUtils] Ninja job ability refactoring to JobUtils #5918

merged 1 commit into from
Jul 16, 2024

Conversation

andeluvian
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR contains the Jobutils for Ninja jobabilities.

Steps to test these changes

Create a player with job Ninja make it 75 or 99 and test each ability, each ability should work as they did originally before the move.
@zach2good zach2good added the squash Reminder to squash commits on merge label Jun 15, 2024
@andeluvian
moved all ninja job abilities to use job_utils
d9bc4fb 
Refactor Ninja jobabilities to jobutils
@andeluvian andeluvian marked this pull request as ready for review July 7, 2024 10:29
zach2good
zach2good approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@zach2good zach2good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically seems fine, I've kicked CI off again to see what it says
@Xaver-DaRed Xaver-DaRed removed the squash Reminder to squash commits on merge label Jul 15, 2024
@zach2good zach2good merged commit 6a03aa5 into LandSandBoat:base Jul 16, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@andeluvian @zach2good @Xaver-DaRed