Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] Add ZNM NPC to unique_event #5953

Draft
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

hooksta4
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Place holder for ZNM NPC's Sanraku and Ryo in unique_event. Will determine which dialog players will get upon talking to either NPC.

Steps to test these changes

None at this time.

@zach2good
Copy link
Contributor

These aren't fast-moving files, so why not just do the rest of the logic now too? Ekokoko is a full example of how this system works.

@hooksta4
Copy link
Contributor Author

So I don't forget it.

@zach2good
Copy link
Contributor

To clarify what I want from this PR: The latching logic for "I have spoken to Sanraku for the first time", and "I have spoken to Sanraku for subsequent times" - which is just a single if/else block if memory serves.

Using a single-line PR as a way for you not to forget that a feature exists is pointless.

@zach2good zach2good marked this pull request as draft July 2, 2024 10:51
@zach2good zach2good changed the title [LUA]Add ZNM NPC to unique_event Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants