Correct the look of suit syle equipment #5987
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Items which have look impacts to equip slots outside of the equipment slots that they occupy were not being displayed correctly.
This PR looks to address that issue. More details and images can be found below.
Changes in this PR.
rslotlook
initem_equipments.sql
. This repesents a bitmask of theSLOT TYPE
which are overrided by a piece of gear for appearance. This is distinctly different from therslot
column which is the bit mask for equipment slots which are exclusive with this item being equipped.item_equipments.sql
UpdateRemovedSlots
to have distinct lockstyle and non-lockstyle versionsSteps to test these changes
Add equipment into the lockstyle in any other slot that will be overriden like hands/legs/feet
![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/105882290/346248709-683cc307-4299-4762-9324-b51b505facbe.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzNTgyMjYsIm5iZiI6MTcyMTM1NzkyNiwicGF0aCI6Ii8xMDU4ODIyOTAvMzQ2MjQ4NzA5LTY4M2NjMzA3LTQyOTktNDc2Mi05MzI0LWI1MWI1MDVmYWNiZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxOVQwMjU4NDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mYjA3YmU4MGVkNDQ1YzlhNzhiNDRkOTk1ZGVkZjFlZDAyMjEwZWZkNGU3NzdhOWRiMzljODJlNzM1ZmFjYTk2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.LX3Op2Fvna5sufXpt1s3xfkqx8OZRKwAxU6WtLIhqKI)
example:
Apply the lock style - and note that there is no "underneath equipment" clipping through
Remove lockstyle, ensure nothing is missing (like the characters hands, legs, or feet)
Create a lockstyle with just the suit and have the full melee set equipped
Apply the lock style - and note that there is no "underneath equipment" clipping through
Remove lockstyle, ensure nothing is missing (like the characters hands, legs, or feet)
Equip the suit item- note that there is no "underneath equipment" clipping through and only the required equip is removed (usually just legs)
Unequip the suit directly - note that hands/legs/feet are as expected and 100% not just missing/invisible
Re-equip the suit
Unequip the suit by equipping an item into its restricted equip slot (i.e. legs) - note that hands/legs/feet are as expected and 100% not just missing/invisible
Repeat 9 - 12 using equipsets
Repeat 9 - 12 using luashitacast
Items impacted by this change:
![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/105882290/346248786-e84bf00b-8e9e-45fc-84ee-f39f3e878cf5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzNTgyMjYsIm5iZiI6MTcyMTM1NzkyNiwicGF0aCI6Ii8xMDU4ODIyOTAvMzQ2MjQ4Nzg2LWU4NGJmMDBiLThlOWUtNDVmYy04NGVlLWYzOWYzZTg3OGNmNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxOVQwMjU4NDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02YzcxOTYyZWI2ODhhMjJlODMzMTc4NGJjMGQ4ZTQ3MWZhZjk5ZTgzNmRmNTIzYTQ0Y2ZhNjM2NWI5MmVkZmQxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.jEKnVh9Ptr8ZteEaJKJj2-Z1bXjUPqXCQuhUm6PEI6w)
Pre change examples:
![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/105882290/346248843-9e595393-3c08-4d68-9f80-2b5a1fb46ced.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzNTgyMjYsIm5iZiI6MTcyMTM1NzkyNiwicGF0aCI6Ii8xMDU4ODIyOTAvMzQ2MjQ4ODQzLTllNTk1MzkzLTNjMDgtNGQ2OC05ZjgwLTJiNWExZmI0NmNlZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxOVQwMjU4NDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iOTFhZmYxZTRhMzhhMDVjMzU2Mjg4NDM4MzBkNDZkNTk4YWUzM2IzOGNiMjE0Yzc5MmE5YjVmNTAxNjFiODFmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.F-KGxQHNhQX2pAXylGppE7eWrunauRv4o4tn-VxABHQ)
Post change examples:
![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/105882290/346248852-4d0d3ad6-e1ee-44dd-ae3f-5da5b6915a27.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzNTgyMjYsIm5iZiI6MTcyMTM1NzkyNiwicGF0aCI6Ii8xMDU4ODIyOTAvMzQ2MjQ4ODUyLTRkMGQzYWQ2LWUxZWUtNDRkZC1hZTNmLTVkYTViNjkxNWEyNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxOVQwMjU4NDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xNTc3ZGYyMTdhNjhjNGIwZmVmMWM2NmUzYTc3OGJmMWVmMGYyMzU4ZjhhZWU4MzhlNDUyN2IwMWUyYzFjNTRjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.JW_tUoNUbNhnaJ7h5DrAMEzcPVXi_U3XwgrA7Zni0mc)
Note The above pictures are taken from ASB testing on PR: AirSkyBoat#3677
I did not re-test all suits - rather focused most of my testin on the
Onca Suit
while doing work on LSB.Rev 2
Found and fixed a bug on the following steps:
updated to