add leetcode.signinByCookie but simple change #487
Conversation
|
Is it possible to leverage the cookie extension: to bypass the reCAPTCHA?
|
|
Yes, but I think this way is not so simple, I will try it tomorrow. |
|
@yihong0618 I just took a look about the document. The cookie plugins need more requirements and they are different for different platforms. So I think it's not an ideal solution. Just forget it. |
|
@jdneo me either. And this solution was for one-time session at that time. |
|
@jdneo |
There was a problem hiding this comment.
Thank you for your effort @yihong0618.
I just have one concern about the command name. Maybe call it Sign in (by cookie) would be more easy to understand?
README.md
Outdated
| - **LeetCode: Sign in** | ||
| - **LeetCode: Cookie in** |
There was a problem hiding this comment.
How about renaming it to Sign in (by cookie)
There was a problem hiding this comment.
Of course, should I also change name in leetcode.cookieIn command ?
There was a problem hiding this comment.
@jdneo
Have changed it~
package.json
Outdated
| "onView:leetCodeExplorer" | ||
| ], | ||
| "main": "./out/src/extension", | ||
| "contributes": { | ||
| "commands": [ | ||
| { | ||
| "command": "leetcode.signinByCookie", | ||
| "title": "Sign In By Cookie", |
There was a problem hiding this comment.
nit: By should be lower case since it's a preposition
There was a problem hiding this comment.
Ok, I will change it right now
|
Hi @yihong0618, almost there. Just a typo. |
|
Hi I fixed the typo, is that right? |
|
LGTM. Thank you @yihong0618 for your contribution! Well done! |
|
Will release this fix before the end of this week |
|
Thank you~ |
This is very simple change maybe for short-term solution for #478
Sorry for the first time write ts.
Please help me review~
@jdneo
Thanks a lot.