Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address x rotation for GLTF #22

Closed
wants to merge 1 commit into from
Closed

Address x rotation for GLTF #22

wants to merge 1 commit into from

Conversation

gkjohnson
Copy link
Contributor

Fix #12

Apply a 90 degree rotation about X to accommodate +Y -> +Z conversion.

Frustum checks seem to be incorrect which this exposed more apparently, which should be fixed.
@gkjohnson
Copy link
Contributor Author

This seems really ill documented and there's no example data to show how the behavior is supposed to work because applying the rotation causes issues in both data sets available. There also seems to be a gltfUpAxis field in the asset object of tileset.json that's no longer in the spec?
@gkjohnson gkjohnson closed this Mar 17, 2020
@gkjohnson gkjohnson deleted the add-x-rotation branch March 17, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@gkjohnson