Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #87

Merged
merged 7 commits into from
Jul 4, 2020
Merged

Small fixes #87

merged 7 commits into from
Jul 4, 2020

Conversation

gkjohnson
Copy link
Contributor

@gkjohnson gkjohnson commented Jul 3, 2020 •
edited
Loading

Fixes for failure cases found related to #78

Fix #82

  • Track the amount of failed tile loads.
  • Stop failed tile loads from preventing the rest of the tiles from loading.
  • Correctly update parse and download stats when a download fails.
  • Propagate image load errors.
  • Fix DebugTilesRenderer giving a different color to each scene child in random color mode
  • Fix TilesRendererBase perpetually requesting a tileset if it's already failed
  • Correctly skip empty tile content

TODO

  • Changelog
  • Add a couple comments, clean up conditions
@gkjohnson gkjohnson added this to the Next Release milestone Jul 3, 2020
@gkjohnson gkjohnson merged commit e482e71 into master Jul 4, 2020
@gkjohnson gkjohnson deleted the small-fixes branch July 4, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@gkjohnson