-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][IMP]l10n_it_fatturapa_in: copy changing values only #4240
base: 14.0
Are you sure you want to change the base?
[14.0][IMP]l10n_it_fatturapa_in: copy changing values only #4240
Conversation
fc93349
to
4b2c86c
Compare
4b2c86c
to
3b311cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
4e8138b
to
c57f2bc
Compare
c57f2bc
to
51a083b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funzionale ok!
This PR has the |
@OCA/local-italy-maintainers si può mergiare? |
@SirAionTech buona per te? |
A me già non convinceva questa parte di codice che prende tutto quello che c'è nella cache e lo scrive. |
@SirAionTech riusciamo a risalire a chi/quando era stata aggiunta questa funzione? |
Fu aggiunta in 773e1c3 (il commit originale è cb063e9) da @eLBati |
Ok, dunque è lì da un bel po' @eLBati hai idea dell'utilità di questa funzione? |
|
@eLBati grazie, secondo te come possiamo intervenire per risolvere il problema indicato nella issue? |
@eLBati ping! Che ne pensi di questa PR? Andiamo a fare danni? |
There's no need to overwrite values when they don't change. Moreover a user might not have permissions to write certain fields (in my case it was
stock_valuation_layer_ids
, which requires the Stock / Administrator group)Solves: #4242