Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] l10n_it_withholding_tax dead code #4251

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[14.0][FIX] l10n_it_withholding_tax dead code #4251

merged 1 commit into from
Jul 10, 2024

Conversation

sergiocorato
Copy link
Contributor

@sergiocorato sergiocorato commented Jul 4, 2024 •
edited
Loading

Rimozione codice non usato.
@sergiocorato sergiocorato force-pushed the 14.0-fix-l10n_it_withholding_tax-dead_code branch 2 times, most recently from 2ff8b9e to 65faca9 Compare July 4, 2024 20:16
SirAionTech
SirAionTech requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Dove viene fatto ora quello che facevano questi metodi?

Come mai non hai creato la issue di tracciamento come descritto in https://github.com/OCA/l10n-italy/wiki/Team-di-sviluppo#apertura-issue?

Come mai il messaggio del secondo commit non segue le linee guida in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message?
l10n_it_withholding_tax/models/account.py Outdated Show resolved Hide resolved
@sergiocorato sergiocorato force-pushed the 14.0-fix-l10n_it_withholding_tax-dead_code branch from 65faca9 to 4d5d0c1 Compare July 8, 2024 15:21
@sergiocorato sergiocorato mentioned this pull request Jul 9, 2024
Closed
2 tasks
@sergiocorato sergiocorato linked an issue Jul 9, 2024 that may be closed by this pull request
Rimozione codice inutilizzato in l10n_it_withholding_tax #4255
Closed
2 tasks
SirAionTech
SirAionTech approved these changes Jul 9, 2024
View reviewed changes
l10n_it_withholding_tax/models/account.py Outdated Show resolved Hide resolved
andreampiovesana
andreampiovesana approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@SirAionTech
Copy link
Contributor

/ocabot merge patch
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-4251-by-SirAionTech-bump-patch, awaiting test results.
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
@OCA-git-bot OCA-git-bot merged commit ca5866d into OCA:14.0 Jul 10, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0308a1c. Thanks a lot for contributing to OCA. ❤️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 ready to merge
4 participants
@sergiocorato @SirAionTech @OCA-git-bot @andreampiovesana