-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Components - _21risk #12734
New Components - _21risk #12734
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App as _21risk.app.mjs
participant API as 21risk API
User ->> App: Call listActions()
App ->> API: Make request to /actions endpoint
API -->> App: Return actions data
App -->> User: Return list of actions
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Sources - New Action - New Auditor - New Report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
Files selected for processing (9)
- components/_21risk/_21risk.app.mjs (1 hunks)
- components/_21risk/package.json (2 hunks)
- components/_21risk/sources/common/base.mjs (1 hunks)
- components/_21risk/sources/new-action/new-action.mjs (1 hunks)
- components/_21risk/sources/new-action/test-event.mjs (1 hunks)
- components/_21risk/sources/new-auditor/new-auditor.mjs (1 hunks)
- components/_21risk/sources/new-auditor/test-event.mjs (1 hunks)
- components/_21risk/sources/new-report/new-report.mjs (1 hunks)
- components/_21risk/sources/new-report/test-event.mjs (1 hunks)
Files skipped from review due to trivial changes (4)
- components/_21risk/sources/new-action/test-event.mjs
- components/_21risk/sources/new-auditor/test-event.mjs
- components/_21risk/sources/new-report/new-report.mjs
- components/_21risk/sources/new-report/test-event.mjs
Additional comments not posted (20)
components/_21risk/package.json (2)
3-3
: Version update approved.The version update from
0.0.1
to0.1.0
is consistent with the addition of new components and methods.
15-18
: New dependency addition approved.The addition of
@pipedream/platform
with version^3.0.0
is necessary for the new components.components/_21risk/sources/new-auditor/new-auditor.mjs (2)
1-3
: Import statements approved.The imports of
common
andsampleEmit
modules are necessary for the component's functionality.
4-25
: New component definition approved.The new component for emitting events when a new auditor is created is well-structured and includes necessary properties and methods.
components/_21risk/sources/new-action/new-action.mjs (2)
1-3
: Import statements approved.The imports of
common
andsampleEmit
modules are necessary for the component's functionality.
4-25
: New component definition approved.The new component for emitting events when a new action is created due to non-compliance in a risk-model category during an audit is well-structured and includes necessary properties and methods.
components/_21risk/_21risk.app.mjs (7)
1-2
: Import statement approved.The import of
axios
from@pipedream/platform
is necessary for making HTTP requests.
7-9
: Base URL method approved.The
_baseUrl
method correctly returns the base URL for requests.
10-14
: Headers method approved.The
_headers
method correctly returns the authorization headers.
15-23
: Make request method approved.The
_makeRequest
method correctly makes requests using Axios with configurable options.
24-29
: List actions method approved.The
listActions
method correctly lists actions using the_makeRequest
method.
30-35
: List auditors method approved.The
listAuditors
method correctly lists auditors using the_makeRequest
method.
36-40
: List reports method approved.The
listReports
method correctly lists reports using the_makeRequest
method.components/_21risk/sources/common/base.mjs (7)
16-17
: LGTM!The
_getLastId
method is correctly implemented.
19-20
: LGTM!The
_setLastId
method is correctly implemented.
22-23
: LGTM!The retrieval of the last seen ID is correctly implemented.
34-39
: LGTM!The handling of the response array and setting the last seen ID is correctly implemented.
41-47
: LGTM!The event emission logic is correctly implemented.
51-52
: LGTM!The
deploy
method is correctly implemented.
55-56
: LGTM!The
run
method is correctly implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- components/_21risk/sources/new-action/new-action.mjs (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- components/_21risk/sources/new-action/new-action.mjs
/approve |
Resolves #12691.
Summary by CodeRabbit
New Features
Improvements
_21risk
app module with new request methods using Axios for better API communication.Version Updates
@pipedream/_21risk
package to version0.1.0
and added a dependency on@pipedream/platform
.