Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sneaking option to controll states #609

Merged
merged 2 commits into from
Nov 5, 2017
Merged

Added sneaking option to controll states #609

merged 2 commits into from
Nov 5, 2017

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Nov 4, 2017

  • added option 'sneak' to setControllState,
  • changed api documentation, added this option there
plexigras
plexigras reviewed Nov 4, 2017
View reviewed changes
lib/plugins/physics.js Outdated
@@ -34,7 +34,8 @@ function inject (bot) {
left: false,
right: false,
jump: false,
sprint: false
sprint: false,
sneak: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint doesn't like the trailing commas, you will need to remove it to confirm to the code style rules
rom1504
rom1504 reviewed Nov 5, 2017
View reviewed changes
lib/plugins/physics.js
} else if (control === 'sneak') {
bot._client.write('entity_action', {
entityId: bot.entity.id,
actionId: state ? 0 : 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 means no sneaking ?
@rom1504 rom1504 merged commit 0d0f491 into PrismarineJS:master Nov 5, 2017
@rom1504
Copy link
Member

rom1504 commented Nov 5, 2017

Thanks !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@Meldiron @rom1504 @plexigras