Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect scaling of BVCs firingrates I#108. #109

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

colleenjg
Copy link
Contributor

Fixes #108.

Added a line when self.cell_fr_norm is initialized in the BVCs to unscale it using self.min_fr and self.max_fr.

BVCs now generate firingrates spanning the full range expected with min_fr and max_fr.

Note: The small overshoot above max_fr mentioned in the issue is not addressed here.

@TomGeorge1234
Copy link
Collaborator

Nice, thank you! Can I just double check...does this work if the min_fr != 0 (i.e if the scaling isn't just multiplicative).

@colleenjg
Copy link
Contributor Author

Yes! I tested it on a variety of combinations, and they all come out correctly (unless the user incorrectly sets min_fr > max_fr, which explodes the values with or without the PR change).

MIN_FR = 8; MAX_FR = 10 => 8.0000 to 10.0175
MIN_FR = 0.1; MAX_FR = 125 => 0.1 to 126.0953

@TomGeorge1234 TomGeorge1234 merged commit cfb7acd into RatInABox-Lab:main Mar 28, 2024
3 checks passed
@TomGeorge1234
Copy link
Collaborator

looks good, just merged! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants