refactor: the directory structure. #763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Only concern is this will probably break every other pending PR. Should we make an effort to get every other PR either closed or merged first? Several PRs are quite stale, so it'd be good to get them cleared up anyway. |
|
Agreed. Is #751 expected to be merged soon? |
|
It's had some testing on every platform, we could probably merge it right now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite so many changes, this PR simply does the following things.
Since we'll add the code generation (#738) and split the package into different levels, the number of projects will increase. Moving the projects to different folders will make the structure more clear. Besides, it's better to allow multiple projects for our example, making it more flexible.