Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

July 2024 binaries #833

Merged
merged 34 commits into from
Jul 11, 2024
Merged

July 2024 binaries #833

merged 34 commits into from
Jul 11, 2024

Conversation

martindevans
Copy link
Member

@martindevans martindevans commented Jul 8, 2024

This updates LLamaSharp to a newer llama.cpp version (1c5eba6f8e628fb0a98afb27d8aaeb3b0e136451). Thanks to @m0nsky and @SignalRT for helping out with this!

This includes a couple of other related changes, due to upstream changes:

  • Upgrade from cuda12.1.0 to cuda12.2.0
  • Changed various build defines from LLAMA_X to GGML_X

There is a major change in how binaries are distributed for development. Previously they were committed into this repo, in the runtimes/deps folder. However, the llama.cpp binaries have no grown over 100MB for CUDA, which exceeds the maximum GitHub file size.

To work around this binaries have been uploaded to a release in another repo (currently here, ownership will be transferred to SciSharp before this PR is closed). A new msbuild action has been added to LLamaSharp.csproj which automatically downloads and unzips the binaries.

Note that this version is now a week out of date, due to the hold up with the new build system. Once this has merged we may want to immediately do another binary update and then do a release. The important thing here is testing that this new approach works on all platforms!

To do:

  • Testing:
    • Windows (CPU)
    • Windows (CUDA)
    • Windows (Vulkan)
    • Linux CPU
    • Linux CUDA
    • Linux Vulkan
    • MacOS
  • Transfer ownership of binaries repo
    • Update csproj file to download from new URL
  • Update nuspec files to include new ggml.dlls
@SignalRT
Copy link
Collaborator

SignalRT commented Jul 9, 2024

@martindevans I tested it on osx and it's working. I also changed the nuget packages to include sgml.

Copy link
Collaborator

@SignalRT SignalRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok to me

@martindevans
Copy link
Member Author

Thanks!

@martindevans
Copy link
Member Author

The race condition in the build has been fixed, thanks to @m0nsky for the hard work!

@martindevans
Copy link
Member Author

@martindevans martindevans marked this pull request as ready for review July 11, 2024 16:17
@martindevans martindevans merged commit 0882fce into master Jul 11, 2024
6 checks passed
@martindevans martindevans deleted the july-2024-binaries branch July 11, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants