Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async implementation of LLamaExecutors #834

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Async implementation of LLamaExecutors #834

merged 3 commits into from
Jul 10, 2024

Conversation

asmirnov82
Copy link
Contributor

Fixes #829
martindevans
martindevans reviewed Jul 8, 2024
View reviewed changes
LLama/LLamaContext.cs Outdated Show resolved Hide resolved
martindevans
martindevans reviewed Jul 8, 2024
View reviewed changes
LLama/LLamaContext.cs Outdated Show resolved Hide resolved
martindevans
martindevans requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@martindevans martindevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a couple of minor nits :)
@martindevans
Copy link
Member

You can ignore the spell check failure, it's from a different change that got merged with incorrect spelling.
@martindevans martindevans merged commit fd28abf into SciSharp:master Jul 10, 2024
5 of 6 checks passed
@martindevans
Copy link
Member

Thanks for this work @asmirnov82!
@asmirnov82 asmirnov82 deleted the 829_executors_async_implementation branch July 11, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@asmirnov82 @martindevans