Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution Kanji Decks #192

Closed
Zakkaruu opened this issue Feb 4, 2023 · 2 comments
Closed

Contribution Kanji Decks #192

Zakkaruu opened this issue Feb 4, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Zakkaruu
Copy link
Contributor

Zakkaruu commented Feb 4, 2023

Hi,

It might seem odd to provide a contribution as an issue, but I am no where near a developer and have never done a pull request. I wanted to contribute kanji decks using a modified version of the anki_decks_maker.py file and other resources in your project.

This script is basically a copy, but it changes the filter_regex, limits the folder search to literacy-1 and literacy-2 for each lesson (where kanji readings and meanings are), and uses some new regex matching to extract the information.

The cards have a few new fields and I have changed the formatting to my preference, which may or may not be what everyone else likes. Essentially it shows the kanji and readings, but you can hover underneath the kanji to show the meaning on the answer card.. It does this using dark mode colors to hide text, but I have done nothing with the light/dark mode logic to hide in light mode as well.

Examples:
image
image
image

So, I'm basically dropping off the files and giving permission to take the modified work. Attached are the pre-built decks. I'm also only a novice 日本語 student, so I believe they are correct, but honestly I'm only into Genki I Chapter 8 myself. I've done spot checks to verify it matches with the website, but it is an extremely small portion of them.

kanji.zip
anki_kanji_decks.py.zip

@SethClydesdale SethClydesdale added the enhancement New feature or request label Feb 4, 2023
@SethClydesdale
Copy link
Owner

Hello @Zakkaruu!

I took a quick look over and everything looks good! I think this'll be a great addition, so I'll look into implementing it into the repository and site when I get the chance. Thank you for taking the time to put this together!

SethClydesdale added a commit that referenced this issue Feb 5, 2023
- added kanji decks thanks to #192.
- updated existing vocab decks so they're synced with recent changes that may have been made to vocab exercises on the site (i.e. typo fixes).
@SethClydesdale
Copy link
Owner

Hi again! As of 8dde722 the kanji decks have been added to the repo! They're also available online here:
https://sethclydesdale.github.io/genki-study-resources/help/anki-decks/#kanji-decks

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants