Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xlsx wordlist generator #109

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

RealFakeAccount
Copy link
Contributor

I sometimes want to print out all the words on paper, so I modified the anki decks generator to generate xlsx file.

If you think this is redundant, feel free to close this pull request.

@SethClydesdale SethClydesdale marked this pull request as ready for review October 29, 2020 01:22
@SethClydesdale SethClydesdale added the enhancement New feature or request label Oct 29, 2020
@SethClydesdale
Copy link
Owner

Hello @RealFakeAccount,

I think this would be a great addition! Can see it coming in handy for quickly referencing the vocab.

Just want to double check with you to see if everything is ready before merging, as I noticed the PR was originally marked as a draft.

@RealFakeAccount
Copy link
Contributor Author

Hello @RealFakeAccount,

I think this would be a great addition! Can see it coming in handy for quickly referencing the vocab.

Just want to double check with you to see if everything is ready before merging, as I noticed the PR was originally marked as a draft.

Hi @SethClydesdale :

Here is my plan for this PR :

  • modify README.md
  • update the bat file
  • generate word lists for 2nd Edition
  • (possibly) add a entry in the main page

Since I'm a little busy this week, I mark this PR as draft for now.
I may have time to finished it this weekend.

BTW, thanks for your project. It helps me a lot.

@RealFakeAccount RealFakeAccount marked this pull request as draft October 29, 2020 02:06
@SethClydesdale
Copy link
Owner

Sounds good! For the main page entry, if you like, you can add it to the news/info module as a new message or onto an existing one.

Since I'm a little busy this week, I mark this PR as draft for now.

That's fine. There's no rush, so whenever you're ready to merge, just let me know! 👍

BTW, thanks for your project. It helps me a lot.

You're welcome! Glad to hear it's of help to you. 😄

@RealFakeAccount
Copy link
Contributor Author

@SethClydesdale I have finished. Please check it.

@RealFakeAccount RealFakeAccount marked this pull request as ready for review November 7, 2020 20:53
Copy link
Owner

@SethClydesdale SethClydesdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry about the delay; I was on vacation.

Everything looks good to merge! 👍

Thank you for taking the time to work on this. I'm looking forward to using the lists that are generated from it.

@SethClydesdale SethClydesdale merged commit 7fd28e8 into SethClydesdale:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants