fix!: 🐛 Fixed TitleAlign Issue #459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added titleAlignment and descriptionAlignment parameters to align title and description within the tooltip widget Renamed parameters titleAlignment to titleTextAlign and descriptionAlignment to descriptionTextAlign
aditya-chavda
suggested changes
Jul 5, 2024
| @@ -11,6 +11,9 @@ A Flutter package allows you to Showcase/Highlight your widgets step by step. | |||
|
|
|||
|  | |||
|
|
|||
| ## Migration guide for release 4.0.0 | |||
| Renamed parameters `titleAlignment` to `titleTextAlign` and `descriptionAlignment` to `descriptionTextAlign` to correspond it more with the TextAlign property | |||
There was a problem hiding this comment.
Please also mention that the existing variables' behaviour/purpose has been changed.
| @@ -252,13 +254,25 @@ class Showcase extends StatefulWidget { | |||
| /// Defaults to 7. | |||
| final double toolTipSlideEndDistance; | |||
|
|
|||
| /// Title alignment within tooltip widget | |||
There was a problem hiding this comment.
Can you please add widget word in there?
Suggested change
| /// Title alignment within tooltip widget | |
| /// Title widget alignment within tooltip widget |
| @@ -439,44 +443,52 @@ class _ToolTipWidgetState extends State<ToolTipWidget> | |||
| : CrossAxisAlignment.center, | |||
There was a problem hiding this comment.
Please see if this is still required after the usage of Align as parent of the children.
| @@ -70,7 +72,7 @@ class ToolTipWidget extends StatefulWidget { | |||
| required this.offset, | |||
| required this.screenSize, | |||
| required this.title, | |||
| required this.titleAlignment, | |||
| required this.titleTextAlign, | |||
There was a problem hiding this comment.
Can you please put this with the other text align and alignment property below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
titleAlignmentanddescriptionAlignmentparameters to align title and description within the tooltip widgettitleAlignmenttotitleTextAlignanddescriptionAlignmenttodescriptionTextAlignChecklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #457