Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DON'T MERGE] Review additional coding style suggestions #8347

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[DON'T MERGE] Review additional coding style suggestions #8347

wants to merge 3 commits into from

Conversation

andrei-epure-sonarsource
Copy link
Contributor

No description provided.

@github-actions github-actions bot added this to In progress in Best Kanban Nov 10, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information
Tim-Pohlmann
Tim-Pohlmann reviewed Nov 13, 2023
View reviewed changes
docs/coding-style.md Outdated Show resolved Hide resolved
Tim-Pohlmann
Tim-Pohlmann reviewed Nov 13, 2023
View reviewed changes
docs/coding-style.md Outdated Show resolved Hide resolved
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from In progress to To do in Best Kanban Feb 20, 2024
zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. Most of my comments are on adding examples (even for seemingly trivial cases), and we have a couple of topics we need to vote on before we can continue.
docs/coding-style.md Outdated Show resolved Hide resolved
docs/coding-style.md Outdated Show resolved Hide resolved
docs/coding-style.md Outdated Show resolved Hide resolved
docs/coding-style.md Outdated Show resolved Hide resolved
docs/coding-style.md Outdated Show resolved Hide resolved
docs/coding-style.md Outdated Show resolved Hide resolved
docs/coding-style.md Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud
pavel-mikula-sonarsource
pavel-mikula-sonarsource reviewed Jun 7, 2024
View reviewed changes
docs/coding-style.md
@@ -39,6 +39,8 @@ int CallerTwo() => Leaf() + PublicMethod();
int Leaf() => 42;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to do a review once it's ready for it.
@github-actions github-actions bot moved this from To do to Review in progress in Best Kanban Jul 7, 2024
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource marked this pull request as ready for review July 7, 2024 07:56
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 7, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 7, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants
@andrei-epure-sonarsource @Tim-Pohlmann @pavel-mikula-sonarsource @gregory-paidis-sonarsource @zsolt-kolbay-sonarsource