Explicit MIME type declaration on querying available packages for ope…

…ning files As noted by Android Studio on the use of android.permission.QUERY_ALL_PACKAGES permission, use <queries> with explicit action and MIME type instead. This also reduces possibility of unrelated apps from popping up in the list of available apps. Additionally, as noted in https://stackoverflow.com/a/55071463, change SQLITE MIME type to application/vnd.sqlite3.
TeamAmaze · Nov 14, 2021 · e3e2e39 · e3e2e39
1 parent fe15d6f
commit e3e2e39
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 3 deletions.
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -37,7 +37,73 @@
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
     <uses-permission android:name="android.permission.REQUEST_DELETE_PACKAGES" />
     <uses-permission android:name="android.permission.MANAGE_EXTERNAL_STORAGE" />
-    <uses-permission android:name="android.permission.QUERY_ALL_PACKAGES" />
+
+    <queries>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="image/*" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="text/*" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="audio/*" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="video/*" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/zip" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/rar" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/x-gzip" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/x-rar-compressed"/>
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/x-bzip2" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/x-xz" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/x-7z-compressed" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/vnd.sqlite3" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/javascript" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/json" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="message/rfc822" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <data android:mimeType="application/vnd.ms-outlook" />
+        </intent>
+    </queries>
 
     <uses-feature
         android:name="android.hardware.touchscreen"
@@ -163,6 +229,7 @@
                 <action android:name="android.intent.action.VIEW"/>
                 <category android:name="android.intent.category.DEFAULT" />
                 <data android:mimeType="db/*" />
+                <data android:mimeType="application/vnd.sqlite3" />
             </intent-filter>
 
         </activity>

diff --git a/app/src/main/java/com/amaze/filemanager/ui/icons/MimeTypes.java b/app/src/main/java/com/amaze/filemanager/ui/icons/MimeTypes.java
@@ -80,8 +80,10 @@ public final class MimeTypes {
     MIME_TYPES.put("ksh", "text/plain");
     MIME_TYPES.put("sh", "application/x-sh");
 
-    MIME_TYPES.put("db", "application/octet-stream");
-    MIME_TYPES.put("db3", "application/octet-stream");
+    MIME_TYPES.put("db", "application/vnd.sqlite3");
+    MIME_TYPES.put("db3", "application/vnd.sqlite3");
+    MIME_TYPES.put("sqlite", "application/vnd.sqlite3");
+    MIME_TYPES.put("sqlite3", "application/vnd.sqlite3");
 
     MIME_TYPES.put("otf", "application/x-font-otf");
     MIME_TYPES.put("ttf", "application/x-font-ttf");