Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit MIME type declaration on querying available packages for opening files #3020

Open
wants to merge 3 commits into
base: release/3.7
Choose a base branch
from
Open

Explicit MIME type declaration on querying available packages for opening files #3020

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bde31f2
Explicit MIME type declaration on querying available packages for ope…
TranceLove Nov 14, 2021
68a23d0
Some more little fixes
TranceLove Nov 16, 2021
fac3235
Changes per PR feedback
TranceLove Nov 18, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Explicit MIME type declaration on querying available packages for ope… 
…ning files

As noted by Android Studio on the use of android.permission.QUERY_ALL_PACKAGES permission, use <queries> with explicit action and MIME type instead. This also reduces possibility of unrelated apps from popping up in the list of available apps.

Additionally, as noted in https://stackoverflow.com/a/55071463, change SQLITE MIME type to application/vnd.sqlite3.
  • Loading branch information
@TranceLove
TranceLove committed Nov 16, 2021
commit bde31f2d013d8f262a6e02a31078d79b571efa5c
93 changes: 92 additions & 1 deletion app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,97 @@
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
<uses-permission android:name="android.permission.REQUEST_DELETE_PACKAGES" />
<uses-permission android:name="android.permission.MANAGE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.QUERY_ALL_PACKAGES" />

<queries>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="image/*" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="text/*" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="audio/*" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="video/*" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/zip" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/rar" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/x-gzip" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/x-rar-compressed"/>
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/x-bzip2" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/x-xz" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/x-7z-compressed" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/vnd.sqlite3" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/javascript" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/json" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="message/rfc822" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/vnd.ms*" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/vnd.sun.xml.*" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/vnd.stardivision.*" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/vnd.oasis.opendocument.*" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/vnd.openxmlformats-officedocument.*" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/epub+zip" />
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:mimeType="application/xml" />
</intent>
</queries>

<uses-feature
android:name="android.hardware.touchscreen"
Expand Down Expand Up @@ -163,6 +253,7 @@
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT" />
<data android:mimeType="db/*" />
<data android:mimeType="application/vnd.sqlite3" />
</intent-filter>

</activity>
Expand Down
6 changes: 4 additions & 2 deletions app/src/main/java/com/amaze/filemanager/ui/icons/MimeTypes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,10 @@ public final class MimeTypes {
MIME_TYPES.put("ksh", "text/plain");
MIME_TYPES.put("sh", "application/x-sh");

MIME_TYPES.put("db", "application/octet-stream");
MIME_TYPES.put("db3", "application/octet-stream");
MIME_TYPES.put("db", "application/vnd.sqlite3");
MIME_TYPES.put("db3", "application/vnd.sqlite3");
MIME_TYPES.put("sqlite", "application/vnd.sqlite3");
MIME_TYPES.put("sqlite3", "application/vnd.sqlite3");

MIME_TYPES.put("otf", "application/x-font-otf");
MIME_TYPES.put("ttf", "application/x-font-ttf");
Expand Down