Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

请确认变量specID #130

Closed
wants to merge 1 commit into from
Closed

请确认变量specID #130

wants to merge 1 commit into from

Conversation

lvpeng
Copy link

@lvpeng lvpeng commented May 24, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • [√ ] 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  1. 具体问题:在阅读下面代码时,对变量specID的命名产生了疑惑,因为此处'135681624','135681628'都是spuID
const specID = ['135681624', '135681628'];
if (specID.indexOf(id) > -1) {
 return allGoods.filter((good) => good.spuId === id)[0];
}
  1. 修改建议: specID更改为spuIDs
const spuID = ['135681624', '135681628'];
if (spuID .indexOf(id) > -1) {
  return allGoods.filter((good) => good.spuId === id)[0];
}

📝 更新日���

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供
Copy link

github-actions bot commented Jul 8, 2024

这个 PR 已经过时了,因为它已经持续 45 天没有任何活动了。 删除 stale 的标签或评论,否则将在 10 天内关闭。

@github-actions github-actions bot added the Stale label Jul 8, 2024
Copy link

此 PR 被自动关闭,因为它已经 stable 停滞了 10 天,没有任何活动。

@github-actions github-actions bot closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant