Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning Node Connect: LSP support #1629

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Aug 29, 2023

Description

This PR adds Lightning Service Provider support to LNC remote connections.

Requires the two following lnd.conf settings:

    protocol.option-scid-alias=true
    protocol.zero-conf=true

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Eclair
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding
@kaloudis kaloudis marked this pull request as ready for review August 29, 2023 04:49
@kaloudis kaloudis marked this pull request as draft August 29, 2023 04:57
@kaloudis
Copy link
Contributor Author

kaloudis commented Aug 29, 2023

Need to update LNC to handle bi-di streams and send the channel accept request back

Tracking here: lightninglabs/lnc-rn#34

@kaloudis kaloudis force-pushed the lnc-lsp-support branch 3 times, most recently from 7c9913e to de25bb2 Compare January 20, 2024 00:30
@kaloudis kaloudis added this to the v0.8.2 milestone Feb 9, 2024
@kaloudis kaloudis removed this from the v0.8.2 milestone Feb 23, 2024
@kaloudis kaloudis added this to the v0.8.3 milestone Mar 5, 2024
@kaloudis kaloudis removed this from the v0.8.3 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant