Fix opening transaction details in Core Lightning

[myxmaster]

Description

This fixes #1862.

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• LndHub
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[kaloudis]

I think is_our_address is CLN only so this will break for LND

[kaloudis]

Nevermind, looks like that's an LND property

[kaloudis]

I figured this would have used txid and output from CLN-rest (see https://github.com/Ride-The-Lightning/c-lightning-REST/blob/master/controllers/listfunds.js#L25) if there was going to be a re-write like this

Otherwise, I would have just added some optional chaining (?.) to prevent the crash.

Maybe I'm missing something

[myxmaster]

We need the is_our_address or an equivalent property for this and listfunds does not provide this. Do you have an idea how to implement this for CLN?

The reason we did not just add a ? is because we think the code is more descriptive now as the last output with is_our_address is used (first we thought the first one would be used).

The question is: Is the last output really the one that should be used? Or maybe rather the one with the biggest amount?