Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TickerProvider -> Singletickerprovider #124

Merged
merged 5 commits into from
Oct 13, 2020
Merged

TickerProvider -> Singletickerprovider #124

merged 5 commits into from
Oct 13, 2020

Conversation

SirusCodes
Copy link
Collaborator

Did changes in fade, rotate and scale. Thanks to @awhitford for fixing Timer issues😊
Issue number #119
@codecov
Copy link

codecov bot commented Oct 12, 2020 •
edited
Loading

Codecov Report

Merging #124 into master will increase coverage by 0.26%.
The diff coverage is 63.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   68.78%   69.04%   +0.26%     
==========================================
  Files           8        8              
  Lines         708      714       +6     
==========================================
+ Hits          487      493       +6     
  Misses        221      221
Impacted Files Coverage Δ
lib/src/scale.dart 66.66% <52.94%> (+0.78%) ⬆️
lib/src/rotate.dart 66.33% <55.00%> (+0.68%) ⬆️
lib/src/fade.dart 63.29% <100.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb43a4d...b3cdbf2. Read the comment docs.
awhitford
awhitford approved these changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@awhitford awhitford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that I did not run this code -- just reviewed it.
@SirusCodes
Copy link
Collaborator Author

It was running on my device(Android).
aagarwal1012
aagarwal1012 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@awhitford awhitford merged commit 28ab296 into aagarwal1012:master Oct 13, 2020
@aagarwal1012
Copy link
Owner

@SirusCodes, thanks for your contribution. I have sent you a collaborator invite, hope to see more contributions from you.
@aagarwal1012 aagarwal1012 mentioned this pull request Oct 14, 2020
Closed
@SirusCodes
Copy link
Collaborator Author

Thanks a lot😊💙
@aagarwal1012 aagarwal1012 linked an issue Oct 14, 2020 that may be closed by this pull request
Can use SingleTickerProviderStateMixin #119
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@SirusCodes @aagarwal1012 @awhitford