Removed the use of static variables in WavyAnimatedTextKit #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 69.04% 68.86% -0.19%
==========================================
Files 8 8
Lines 714 713 -1
==========================================
- Hits 493 491 -2
- Misses 221 222 +1
Continue to review full report at Codecov.
|
Closed
Closed
awhitford
requested changes
Oct 16, 2020
awhitford
requested changes
Oct 17, 2020
lib/src/wavy.dart
Outdated
| int txtInMoInd = progress.floor(); | ||
| double _percent = progress - txtInMoInd; |
There was a problem hiding this comment.
Sorry I didn't notice this before, but a local variable should not have an underscore prefix -- that's confusing.
There was a problem hiding this comment.
Will do this too
- _percent from local variable
awhitford
approved these changes
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #125
@awhitford Ig this should solve the issue