#44 fix #70
Merged
#44 fix #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat : rotating text
Feat : typewriter
Feat : colorizer
…ansition height and added its default value
* docs: update README.md * docs: create .all-contributorsrc * docs: updated readme
* docs: update README.md * docs: update .all-contributorsrc
* docs: update README.md * docs: update .all-contributorsrc
* Typer Class Enhancments Refer to issue aagarwal1012#34 The Typer Class has been greatly improved in term of control. ### Let's start with breaking changes : ####The duration parameter has become two new ones : speed and pause * speed is the elapsed time between the animation of each characters of a text (Default is 40 ms) * pause is the pause duration between texts (Default is 500 ms) ### New features : ####Three new callbacks come alongside the onTap : * onNext(int index, bool isLast) - This callback will be called before the next text animation, after the previous one's pause. * onNextBeforePause(int index, bool isLast) - This callback will be called before the next text animation, before the previous one's pause. * onFinished - This callback is called at the end, if the parameter isRepeatingAnimation is set to false ####Two new arguments : * displayFullTextOnTap - If true, tapping the screen will stop current animated text, and display it fully for min(remaining, pause) time. (Default is false) * stopPauseOnTap - If true, tapping during a pause will stop it and start the next text animation (Default is false) ####The text list parameter now accept either strings, or map where you can give a text custom speed and pause. If you like thoses changes, I'll make another commit with updated readme regarding this PR with code examples. * Fix indentation issues for Travis * Fix indentation issues for Travis * Fix formating issue in travis
Enhanced different classes of AnimatedTextKit
Added TextLiquidFill animation to AnimatedTextKit
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci]
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci]
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 63.96% 63.96%
=======================================
Files 7 7
Lines 655 655
=======================================
Hits 419 419
Misses 236 236 Continue to review full report at Codecov.
|
| @@ -1,10 +1,11 @@ | |||
| #!/bin/sh | |||
| # This is a generated file; do not edit or check into version control. | |||
| export "FLUTTER_ROOT=C:\flutter" | |||
| export "FLUTTER_APPLICATION_PATH=E:\flutter_projects\Animated-Text-Kit\example" | |||
| export "FLUTTER_APPLICATION_PATH=C:\Users\Legion\AndroidStudioProjects\Animated-Text-Kit\example" | |||
There was a problem hiding this comment.
@AadumKhor, please add this file to .gitignore and remove it from the git history.
aagarwal1012
requested changes
May 14, 2020
There was a problem hiding this comment.
@AadumKhor, please resolve the comment that I mentioned, otherwise this PR looks fine.
aagarwal1012
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #44 was about
RotateAnimatedTextKitnot being centered. I checked by addingAlignment.Centerbut that worked in one particular case only which is why I made a comment. The problem however is not resolved by using this parameter since our code does not usewidget.alignmentanywhere, making that parameter useless. The problem this PR solves is that it takes into account the 'alignment' parameter of the widget which was not being used and accordingly adjust the position of the text. The only drawback I see presently is that genericAlignmentGeometryoptions likeAlignment.centerwould not work, ratherAlignment(double x, double y)format would have to be used.We can add this part to the docs for clarification.
Looking forward to your feedback.