Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #58 resolved #74

Merged
merged 132 commits into from
May 18, 2020
Merged

Issue #58 resolved #74

merged 132 commits into from
May 18, 2020

Conversation

AadumKhor
Copy link
Collaborator

Added a check to ensure that dispose is not called multiple times and setState is not called after dispose. Also refactored the code at some places.

@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   61.97%   61.97%           
=======================================
  Files           7        7           
  Lines         647      647           
=======================================
  Hits          401      401           
  Misses        246      246           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b0f85...e3b0f85. Read the comment docs.

@AadumKhor
Copy link
Collaborator Author

@aagarwal1012 I have no idea how there are 131 commits. This might be because of that history rewrite for removing flutter_export_environment.sh. Will do a squash merge.

@aagarwal1012 aagarwal1012 merged commit 13da380 into aagarwal1012:master May 18, 2020
@aagarwal1012
Copy link
Owner

@allcontributors add @AadumKhor for maintaining the package, implementing ideas, and bug resolving.

@allcontributors
Copy link
Contributor

@aagarwal1012

I've put up a pull request to add @AadumKhor! 🎉

@aagarwal1012
Copy link
Owner

@allcontributors add @AadumKhor for maintaining the package, implementing ideas, and bug resolving.

@allcontributors
Copy link
Contributor

@aagarwal1012

I've put up a pull request to add @AadumKhor! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants