Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto detects Japanese pages and adds furigana to them. #45

Closed
4 tasks done
aiktb opened this issue Apr 7, 2024 · 2 comments
Closed
4 tasks done

Auto detects Japanese pages and adds furigana to them. #45

aiktb opened this issue Apr 7, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@aiktb
Copy link
Owner

aiktb commented Apr 7, 2024

Is your feature request related to a problem? Please describe.

This issue is used to track the progress of feature implementation in the comments following.
image

Describe the solution you'd like

Nothing

Describe alternatives you've considered

No response

Additional context

No response

Validations

  • Check if you're on the latest Furigana Maker version.
  • Follow our Code of Conduct
  • Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
  • I would like to implement this feature via a PR.
@aiktb aiktb added the enhancement New feature or request label Apr 7, 2024
@aiktb aiktb self-assigned this Apr 7, 2024
@wr1159 wr1159 mentioned this issue Jun 13, 2024
4 tasks
@aiktb
Copy link
Owner Author

aiktb commented Jun 24, 2024

The current implementation is so bad that when twitter.com migrated to x.com, this extension quickly lost 300+ users.

I will start implementing this right away to decouple this extension from specific CSS selectors.

One idea was to use [lang=ja], which covers most of the use cases for this extension and is relatively simple to implement.

@aiktb
Copy link
Owner Author

aiktb commented Jul 14, 2024

Closed by #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
1 participant