Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule change alerts on extension updates. #83

Closed
4 tasks done
aiktb opened this issue Jun 13, 2024 · 1 comment
Closed
4 tasks done

Add rule change alerts on extension updates. #83

aiktb opened this issue Jun 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@aiktb
Copy link
Owner

aiktb commented Jun 13, 2024

Is your feature request related to a problem? Please describe.

For example, when twitter.com migrates to x.com, what should be done to update the old rules and prevent conflicts?

Describe the solution you'd like

One possible solution is to add a dialog to options.html that lets users choose whether they want to import new rules or delete outdated ones, etc.
The callback to open the options page and pop up the dialog should be registered in the event listener that the extension update.

Describe alternatives you've considered

No response

Additional context

Important

If the user updates more than one version at a time, the changes from these versions should be merged and shown to the user.

Validations

  • Check if you're on the latest Furigana Maker version.
  • Follow our Code of Conduct
  • Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
  • I would like to implement this feature via a PR.
@aiktb aiktb changed the title Add rule change alerts on expansion updates. Jun 13, 2024
@aiktb aiktb self-assigned this Jun 13, 2024
@aiktb aiktb added the enhancement New feature or request label Jun 13, 2024
@aiktb
Copy link
Owner Author

aiktb commented Jul 14, 2024

No longer necessary, wxt/stroage provides a good mechanism to migrate storage versions, it's simple.
And with auto-detection complete, updating the rules list in real time is no longer important.

@aiktb aiktb closed this as completed Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
1 participant