Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RTL mode): UI/UX improvement for Right-To-Left users #5552

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Alimadadi
Copy link

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

These commits will fix some UI/UX bugs in RTL (right-to-left) mode. None of these changes will affect LTR mode.

…ce and better UI/UX in RTL mode (this commit doesn't affect UI/UX in LTR mode)
…oogle to prepare RTL mode, optional arguments are set to their default values. Now they just need to change NbLayoutDirection.LTR to NbLayoutDirection.RTL and the theme switchs to RTL mode.
…n RTL mode (this commit doesn't affect UI/UX in LTR mode)
… (this commit doesn't affect UI/UX in LTR mode)
… (this commit doesn't affect UI/UX in LTR mode)
…n RTL mode (this commit doesn't affect UI/UX in LTR mode)
…n RTL mode (this commit doesn't affect UI/UX in LTR mode)
…n RTL mode (this commit doesn't affect UI/UX in LTR mode)
Copy link

@alhussien76 alhussien76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi,
this sol doesn't change the dir attribute in html tag, and this is the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants