Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix api invoke event pass fail bug #1086

Merged
merged 1 commit into from
Feb 20, 2021
Merged

fix api invoke event pass fail bug #1086

merged 1 commit into from
Feb 20, 2021

Conversation

SquatsTonight
Copy link
Collaborator

  1. 修复 api-invoke 时 event 传输失败 bug
  2. 将 FC_INITIALIZATION_TIMEOUT 环境变量名称修改回 FC_INITIALIZATIONTIMEOUT，适配 fc-docker 镜像版本 1.9.13
rsonghuster
rsonghuster reviewed Feb 19, 2021
View reviewed changes
src/lib/local/api-invoke.js Outdated
const containerName = docker.generateRamdomContainerName();
const event = await getHttpRawBody(req);

if (this.functionProps.Initializer) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var invokeInitializer= false;
if (this.functionProps.Initializer) {
invokeInitializer= true;
}

this.cmd = docker.generateDockerCmd(this.runtime, false, {
functionProps: this.functionProps,
httpMode: true,
invokeInitializer: invokeInitializer,
event
});

为什么不这么写呢
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
@rsonghuster rsonghuster merged commit 558dd0a into master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@SquatsTonight @rsonghuster