Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete block by Id, and disable snap on minor block move #65

Closed
wants to merge 2 commits into from
Closed

Delete block by Id, and disable snap on minor block move #65

wants to merge 2 commits into from

Conversation

pilootchoum
Copy link

No description provided.

@pilootchoum
Add DeleteBlock by Id function
e441e16 
Deleting one block identified by its id, and all of its children.
@pilootchoum
Preventing block move if minor move
1a42471 
Added the ability to prevent a block from snapping, or rearranging if move is minor, defined here by 50 px move minimum, could be easily changed, or setted up in conf of flowy object.
To avoid tree being rearranged when a block is just clicked on .
@jamessampford
Copy link

Would it be better to call this something like deleteBranch as it will ultimately remove the branch from that ID? eg. If we had the branch A > B > C > D, and we want to remove C, we would be left with just A > B

We could then add use deleteBlock to simply delete a single block and essentially promote the children. eg. If we had the branch A > B > C > D, and we want to remove C, we would be left with A > B > D

This would make this a little more future proof when the functionality to insert a block between 2 existing blocks is put in place
@madan-ram madan-ram mentioned this pull request May 19, 2022
Open
@magnumfonseca
Copy link

@alyssaxuu will we have this snap on minor block move implemented?
@pilootchoum will you continue this PR?
@pilootchoum pilootchoum closed this by deleting the head repository Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@pilootchoum @jamessampford @magnumfonseca