[Jetcaster] Improve scrolling in Home screen #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arriolac
force-pushed
the
chris/jetcaster_scrolling
branch
3 times, most recently
from
239c2cb
to
18fb54e
Compare
Changes: * Support scrolling entire content in home screen * Fix `PreviewHomeContent` * Remove non-screen composable view model usages
arriolac
force-pushed
the
chris/jetcaster_scrolling
branch
from
18fb54e
to
836c888
Compare
bentrengrove
approved these changes
Feb 27, 2024
| if (featuredPodcasts.isNotEmpty()) { | ||
| Spacer(Modifier.height(16.dp)) | ||
| stickyHeader { | ||
| if (homeCategories.isNotEmpty()) { |
There was a problem hiding this comment.
nit: It should be the other way around I think?
if (homeCategories.isNotEmpty()) {
stickyHeader {}
}
There was a problem hiding this comment.
Good catch. Fixed it
Comment on lines
282
to
290
| ) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: This is super nested, consider breaking it apart into multiple composables where it makes sense
| .windowInsetsTopHeight(WindowInsets.statusBars) | ||
| ) | ||
| val scrimColor = MaterialTheme.colors.primary.copy(alpha = 0.38f) | ||
| Scaffold( |
There was a problem hiding this comment.
Do we even need the Scaffold? Looks like it is sitting in a Column already that maybe could just be used seeing as its just a TopAppBar and then LazyColumn
There was a problem hiding this comment.
I was thinking a Scaffold would be good if we want the top app bar to dismiss while scrolling. Since I haven't implemented that yet (requires M3) I'll remove the Scaffold for now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
PreviewHomeContentIt would be great to also support collapsing the toolbar while scrolling but that might be better accomplished when migrating Jetcaster to Material3.
jetcaster_scrolling.webm