[Reply] Contrast aware updates. #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added colors for standard, medium, and high in both light and dark themes. Added helper function to select contrast level based on values from SysUI controls. Added more variance in application of surface container roles to better indicate elevation and emphasis.
Code formatting.
Formatting.
IanGClifton
reviewed
Mar 20, 2024
| ) | ||
| } | ||
| Spacer(modifier = Modifier.width(8.dp)) |
There was a problem hiding this comment.
Nit: This spacing is a combination of line 115 and line 129. I'd combine them to just do 12dp in one place, probably 115, but I don't have a strong preference whether it's that or a spacer with no horizontalArrangement
| } | ||
|
|
||
| MaterialTheme( | ||
| colorScheme = replyColorScheme, | ||
| typography = replyTypography, | ||
| shapes = shapes, | ||
| typography = replyTypography, shapes = shapes, |
There was a problem hiding this comment.
Nit: Should still be separate lines
| content = content | ||
| ) | ||
| } | ||
|
|
||
| @Composable | ||
| fun ReplyTheme( |
There was a problem hiding this comment.
Is the ReplyTheme still used anywhere?
There was a problem hiding this comment.
It was being used in previews but I've replaced all those references and removed ReplyTheme. Done.
Removed partially used theme and implemented code style suggestions. Modified selectSchemeForContrast function to allow it to pass through on API versions without contrast support.
…ples into jwill/reply-contrast
IanGClifton
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added colors for standard, medium, and high in both light and dark themes.
Added helper function to select contrast level based on values from SysUI controls.
Added more variance in application of surface container roles to better indicate elevation and emphasis.