Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetcaster] Migrate from M2 to M3. #1287

Merged
merged 10 commits into from
Mar 20, 2024

Conversation

arriolac
Copy link
Contributor

@arriolac arriolac commented Mar 19, 2024

Upgrading Jetcaster from M2 to M3. This migration changes one of the original purposes of the sample which was to demonstrate dynamic theming. We would still like to demonstrate dynamic theming but using a more modern approach using Material's material-color-utilities.
Screenshot_20240319_131815

@arriolac arriolac requested a review from a team as a code owner March 19, 2024 17:54
@arriolac arriolac requested a review from mlykotom March 19, 2024 17:54
@arriolac arriolac requested review from bentrengrove and removed request for mlykotom March 19, 2024 18:05
@bentrengrove
Copy link
Member

The status bar color doesn't look correct in your screenshot, should be white.

@arriolac
Copy link
Contributor Author

The status bar color doesn't look correct in your screenshot, should be white.

That change is intentional — though the status bar should match surface color. Updating that

@bentrengrove
Copy link
Member

Does the contrast of the text on the status bar color look correct now? Hard to tell from the code

@arriolac
Copy link
Contributor Author

arriolac commented Mar 20, 2024

Does the contrast of the text on the status bar color look correct now? Hard to tell from the code

Ahh good catch. I didn't notice the status bar text contrast. Looks like there was a bug in JetcasterTheme.

Screenshots:
dark_mode_
light_mode

@arriolac arriolac merged commit 21cffa3 into jetcaster/all_form_factors Mar 20, 2024
1 check passed
@arriolac arriolac deleted the chris/jetcaster/m3 branch March 20, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants