-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetcaster] Handle no subscribed podcasts empty state #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arriolac
force-pushed
the
chris/jetcaster/empty
branch
from
March 21, 2024 20:33
ab9dc9f
to
a3a2f9c
Compare
arriolac
force-pushed
the
chris/jetcaster/empty
branch
from
March 21, 2024 20:36
a3a2f9c
to
59462de
Compare
arriolac
force-pushed
the
chris/jetcaster/empty
branch
from
March 21, 2024 23:30
5b90538
to
9ead83b
Compare
arriolac
force-pushed
the
chris/jetcaster/empty
branch
from
March 22, 2024 00:04
495df92
to
c9537eb
Compare
Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/Home.kt
Outdated
Show resolved
Hide resolved
Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/Home.kt
Outdated
Show resolved
Hide resolved
Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/Home.kt
Outdated
Show resolved
Hide resolved
Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/Home.kt
Outdated
Show resolved
Hide resolved
arriolac
force-pushed
the
chris/jetcaster/empty
branch
from
March 25, 2024 21:54
b899958
to
c0846c5
Compare
Co-authored-by: Ben Trengrove <bentrengrove@users.noreply.github.com>
arriolac
force-pushed
the
chris/jetcaster/empty
branch
from
March 25, 2024 21:56
c0846c5
to
35f192c
Compare
kul3r4
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
arriolac
added a commit
that referenced
this pull request
Mar 26, 2024
Introduces `EpisodePlayer` interface and `MockEpisodePlayer` conforming class to mock playing an episode. This enables play/pause and the slider to update as you would expect in a real podcast app. [Screen_recording_20240322_160937.webm](https://github.com/android/compose-samples/assets/463186/09a4e7bd-7d99-4381-8ec2-9b2af3bfefac) #1292 should be reviewed and merged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
FollowedPodcasts
to useHorizontalPager
so that the list of episodes changes as the user swipes through podcastsScreen_recording_20240321_163113.webm