Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a screen to show the details of the selected episode #1304

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Add a screen to show the details of the selected episode #1304

merged 1 commit into from
Apr 1, 2024

Conversation

chikoski
Copy link
Contributor

@chikoski chikoski commented Apr 1, 2024

This pull request adds a screen to show the details of the selected episode.

In addition to that, some improvement on focus management is also included in this pull request as follows:

  • Set focusRestorer to the following components:
    • PodcastRow
    • EpisodeRow
  • Change the tabRow in the discover screen to get the current tab selected when d-pad focus enters to the row
  • Change the Library screen to get the first podcast in the PodcastRow selected when users navigate to the screen
@chikoski chikoski requested a review from a team as a code owner April 1, 2024 07:11
@chikoski chikoski requested review from arriolac and kul3r4 April 1, 2024 07:11
arriolac
arriolac approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note that PR #1296 introduces new UI models. You may want to consider using those once that PR is merged so that your UI doesn't depend directly on database models. No action needed, more of an FYI
@chikoski chikoski merged commit c90430c into android:jetcaster/all_form_factors Apr 1, 2024
3 checks passed
@chikoski chikoski deleted the jetcaster/add_play_screen_to_tv branch April 2, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@chikoski @arriolac