Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: a build error happening on TV app module #1307

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Fix: a build error happening on TV app module #1307

merged 4 commits into from
Apr 2, 2024

Conversation

chikoski
Copy link
Contributor

@chikoski chikoski commented Apr 2, 2024

This PR fixes a build issue happening on tv-app module. The issue was cased by the resolution failure of BasicTextField2.

More specifically the following change happen by this PR:

  • Switching from BasicTextFiled2 to BasicTextField
  • Modification on DiscoverScreenViewModel to remove line breaks causing a layout glitch
  • Passing supportingContent parameter to ListItem instead of putting everything in the content parameter
@chikoski chikoski requested a review from a team as a code owner April 2, 2024 04:05
@chikoski chikoski requested review from bentrengrove and arriolac and removed request for bentrengrove April 2, 2024 04:05
arriolac
arriolac approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@arriolac arriolac merged commit bad6d5c into android:jetcaster/all_form_factors Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@chikoski @arriolac