Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetcaster] Wear - adds navigation to player, cleanup #1316

Merged

Conversation

kul3r4
Copy link
Contributor

@kul3r4 kul3r4 commented Apr 4, 2024

  • Adds navigation to Player from latest episodes and setting the URI via EpisodePlayer
  • Cleanup
  • Restructured the Dialog for when the content is empty
@kul3r4 kul3r4 requested a review from arriolac April 4, 2024 21:04
@kul3r4 kul3r4 requested a review from a team as a code owner April 4, 2024 21:04
@kul3r4 kul3r4 force-pushed the jetcaster/all_form_factors branch 2 times, most recently from 8f52132 to e05d44f Compare April 5, 2024 15:37
@arriolac arriolac changed the title adds navigation to player, cleanup Apr 5, 2024
val volumeViewModel: VolumeViewModel = viewModel(factory = VolumeViewModel.Factory)

// TODO remove from MediaPlayerScaffold
val snackBarManager: SnackbarManager = SnackbarManager()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these needed or can these be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's leave them for now as I will need to add snackbar messages anyway for when added to queues.

onDismiss = { haveDismissedDialog = true },
content = {
if (viewState.podcastCategoryFilterResult.topPodcasts.isNotEmpty()) {
items(viewState.podcastCategoryFilterResult.topPodcasts.take(1).size) { index ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block can be simplified to:

                val podcast = viewState.podcastCategoryFilterResult.topPodcasts.first()
                item {
                    PodcastContent(
                        podcast = podcast,
                        downloadItemArtworkPlaceholder = rememberVectorPainter(
                            image = Icons.Default.MusicNote,
                            tintColor = Color.Blue,
                        ),
                        onClick = {
                            onTogglePodcastFollowed(podcast)
                        },
                    )
                }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done!

@kul3r4 kul3r4 force-pushed the jetcaster/all_form_factors branch from e05d44f to 85176c0 Compare April 8, 2024 10:08
@kul3r4 kul3r4 force-pushed the jetcaster/all_form_factors branch from 85176c0 to 71d7dce Compare April 8, 2024 10:12
@kul3r4 kul3r4 merged commit c599b2b into android:jetcaster/all_form_factors Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants