Show single pane on phone in landscape #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkoren
commented
Apr 5, 2024
| } | ||
| } | ||
|
|
||
| private fun androidx.window.core.layout.WindowSizeClass.isCompact(): Boolean = |
There was a problem hiding this comment.
There are currently two different WindowSizeClass symbols, one in androidx-window (used by the adaptive deps), and one in material3-window-size-class. I think things are moving towards the androidx-window one, and I have a mind to migrate all usages of the other, but not sure if this PR is the right place for that.
There was a problem hiding this comment.
Thanks for calling that out. Yeah we can make that migration on a separate PR
arriolac
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.